Hey David,
thanks for this feedback!
Regarding the "File (...) does not exist" log warnings you can ignore them. We'll change them to verbose messages so they won't show up in the log on a default setup - it really is pure noise. So
> Functions can take a while to load, so putting some sort of place-holder in the WYSIWYG editor while they are loading would be a good idea.
> ...
> The functions don't appear to have any chrome around them
This is what I see - http://screencast-o-matic.com/watch/c2hVXgnwEZ the red spinner image is animated if loading takes any longer than a second or two.
Can you provide access to your solution so we can see why you get a different experience? Perhaps try flushing your browser cache and see if this does anything for you.
> Functions linking to YouTube
Here the problem is Flash - the headless browser we use to render the preview (PhantomJS) does not come with a flashplayer - so we cannot give a good view on Flash content :/
> Is there a way to override the size that the function is displayed?
No - kind of by design, since we are bending over backwards to render the function preview as exact to "real life" as possible. We (at least try to) ensure that the width will match the editing window, but never be wider than the real rendering. We also set the with of the editing window to never exceed the width of the placeholder you are editing. We render the template and calculate the width of things to do this.
We do have a maximum height though - I think it is around 600px - anything beyond that we cut away. Here we're considering some visualization that make the user understand things have been cut at the bottom.
Can you visualize a situation where you would like a preview to behave differently than the current behaviour?
A general note here: we've build this whole thing in a way where you as a developer should not care about the function preview - things should just work "perfectly", even with C1 Functions you wrote 3 years ago. As a fail safe we do provide a flag you can use in your function code to act differently when you are providing a preview - use Composite.Core.WebClient.Renderings.Page.PageRenderer.RenderingReason
> I also had a red log item reported during the upgrade:
We need to to look into this. If you restart the website, do you get these errors again?
Marcus
thanks for this feedback!
Regarding the "File (...) does not exist" log warnings you can ignore them. We'll change them to verbose messages so they won't show up in the log on a default setup - it really is pure noise. So
> Functions can take a while to load, so putting some sort of place-holder in the WYSIWYG editor while they are loading would be a good idea.
> ...
> The functions don't appear to have any chrome around them
This is what I see - http://screencast-o-matic.com/watch/c2hVXgnwEZ the red spinner image is animated if loading takes any longer than a second or two.
Can you provide access to your solution so we can see why you get a different experience? Perhaps try flushing your browser cache and see if this does anything for you.
> Functions linking to YouTube
Here the problem is Flash - the headless browser we use to render the preview (PhantomJS) does not come with a flashplayer - so we cannot give a good view on Flash content :/
> Is there a way to override the size that the function is displayed?
No - kind of by design, since we are bending over backwards to render the function preview as exact to "real life" as possible. We (at least try to) ensure that the width will match the editing window, but never be wider than the real rendering. We also set the with of the editing window to never exceed the width of the placeholder you are editing. We render the template and calculate the width of things to do this.
We do have a maximum height though - I think it is around 600px - anything beyond that we cut away. Here we're considering some visualization that make the user understand things have been cut at the bottom.
Can you visualize a situation where you would like a preview to behave differently than the current behaviour?
A general note here: we've build this whole thing in a way where you as a developer should not care about the function preview - things should just work "perfectly", even with C1 Functions you wrote 3 years ago. As a fail safe we do provide a flag you can use in your function code to act differently when you are providing a preview - use Composite.Core.WebClient.Renderings.Page.PageRenderer.RenderingReason
> I also had a red log item reported during the upgrade:
We need to to look into this. If you restart the website, do you get these errors again?
Marcus